This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][GOLD] Avoid linker crashing when merge sections have uneven sizes.
- From: Ian Lance Taylor <iant at google dot com>
- To: Doug Kwan (éæå) <dougkwan at google dot com>
- Cc: binutils <binutils at sourceware dot org>
- Date: Thu, 08 Apr 2010 16:54:28 -0700
- Subject: Re: [PATCH][GOLD] Avoid linker crashing when merge sections have uneven sizes.
- References: <u2z498552561004081641sc8a4eb3ci5e9a588634dbf6c3@mail.gmail.com>
"Doug Kwan (éæå)" <dougkwan@google.com> writes:
> This patch fixes a problem exposed by bootstrapping gcc. libjava
> contains objects with unevenly sized merge sections, whose sections
> sizes are not multiples of their entsizes.
That sounds like a bug somewhere.
> 2010-04-08 Doug Kwan <dougkwan@google.com>
>
> * merge.cc (Output_merge_data::set_final_data_size): Handle empty
> Output_merge_data.
> * output.cc (Output_section::add_merge_input_section): Simplify
> code and return status of Output_merge_base::add_input_section.
> Update merge section map only if Output_merge_base::add_input_section
> returns true.
This is OK.
Thanks.
Ian