This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [GOLD][PATCH] Remove Output_section::Simple_input_section class.


"Doug Kwan (éæå)" <dougkwan@google.com> writes:

> å 2010å5æ19æäå11:49ïIan Lance Taylor <iant@google.com> åéï
>
>>> @@ -1215,7 +1219,7 @@ class Arm_input_section : public Output_
>>>    // Address alignment of the original input section.
>>>    uint64_t original_addralign_;
>>>    // Section size of the original input section.
>>> -  uint64_t original_size_;
>>> +  off_t original_size_;
>>
>> This change doesn't seem quite right.  Why should the size of a
>> section be represented by an off_t value?  off_t is for file offsets,
>> not sizes.  On the other hand, since this is ARM which is known to be
>> a 32-bit target, it would be fine to use uint32_t here.
>
> We use off_t for data_size() in Output_data and its sub-classes.   I
> changed this to make it consistent.  I agree that uint32_t is
> sufficient for ARM and will change this.

Oh yeah.  That dates back to when I created output.h.  It should
probably change at some point.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]