This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch][gold] Fix PR11604
- From: Cary Coutant <ccoutant at google dot com>
- To: Rafael Espindola <espindola at google dot com>
- Cc: Binutils <binutils at sourceware dot org>, Sriraman Tallam <tmsriram at google dot com>, Ian Lance Taylor <iant at google dot com>
- Date: Mon, 24 May 2010 12:02:37 -0700
- Subject: Re: [patch][gold] Fix PR11604
- References: <AANLkTinqASwRpQGtZxVxkuN1C-Mh1rwU77mRCDLjPEX-@mail.gmail.com>
> With the attached patch gold can, with the llvm plugin, pass the test in
>
> http://llvm.org/releases/2.6/docs/LinkTimeOptimization.html
>
> The last remaining issue was that the delayed layout would add back a
> section the garbage collector decided was not needed.
>
> I have ported the test to use the test plugin by checking in the original
> .syms file but a .c file that reflects what LTO can do with it.
The fix to Sized_relobj::do_layout_deferred_sections looks good to me (thanks!).
In the test case, plugin_test_7_1.syms should be derived automatically
from plugin_test_7_1.o, rather than checked in as a source file.
-cary