This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH][GOLD] Use offsets within output sections during a relocatable link.


Hi,

    This patch fixes a problem that broke some loadable kernel modules
linked with the -r option.  We used output addresses, instead of
offsets relative to starts of output sections when we finalized values
of local symbols in merged sections.  The same problem potentially
affects relaxed sections and is also fixed by this patch.  I am not
sure if I should change the handling of section and TLS symbols so I
leave them alone.

This is tested by running the whole gold testsuite on x86_64 and
building the ARM linux kernel with a loadable module.  The kernel
module worked only with this patch.

-Doug


2010-05-27  Doug Kwan  <dougkwan@google.com>

        * object.cc (Sized_relobj::do_finalize_local_symbols): Use offset
        from start of output section instead of address for a local symbol
        in a merged or relaxed section when doing a relocatable link.

Attachment: patch-merged-local-symbol.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]