This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fix shadowed variable i when DEBUG386 is on


On Mon, Jun 7, 2010 at 17:04, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Mon, Jun 7, 2010 at 2:56 PM, Quentin Neill
> <quentin.neill.gnu@gmail.com> wrote:
>> When building i386 assembler with -DDEBUG386 we get:
>> config/tc-i386.c: In function 'pi':
>> config/tc-i386.c:2344: error: declaration of 'i' shadows a global declaration
>> config/tc-i386.c:365: error: shadowed declaration is here
>>
>> This fix renames it to j. ?Tested with "make check" on x86. ?Okay to commit?
>>
>> gas:
>> ? ?* config/tc-i386.c (pi): Rename local loop counter
>> ? ?variable i that shadows global static i386_insn i
>> ? ?when DEBUG386 is defined.
>> ? ?(pte) Ditto.
>>
>
> OK.

Committed.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]