This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [GOLD][PATCH][ARM] Pass the objects with unknown eabi version
- From: Ian Lance Taylor <iant at google dot com>
- To: <vkutuzov at accesssoftek dot com>
- Cc: Doug Kwan (éæå) <dougkwan at google dot com>, binutils <binutils at sourceware dot org>
- Date: Tue, 15 Jun 2010 09:27:49 -0700
- Subject: Re: [GOLD][PATCH][ARM] Pass the objects with unknown eabi version
- References: <1276283874.4135.112.camel@dp690-dev5v11.accesssoftek.com>
Viktor Kutuzov <vkutuzov@accesssoftek.com> writes:
> please find attached patch that allows a linking of the ARM object files
> without any EABI specific stuff by default.
>
> -Viktor
>
> Index: arm.cc
> ===================================================================
> RCS file: /cvs/src/src/gold/arm.cc,v
> retrieving revision 1.107
> diff -u -r1.107 arm.cc
> --- arm.cc 8 Jun 2010 00:33:41 -0000 1.107
> +++ arm.cc 11 Jun 2010 17:28:04 -0000
> @@ -9394,7 +9400,8 @@
> {
> // v4 and v5 are the same spec before and after it was released,
> // so allow mixing them.
> - if ((v1 == elfcpp::EF_ARM_EABI_VER4 && v2 == elfcpp::EF_ARM_EABI_VER5)
> + if ((v1 == elfcpp::EF_ARM_EABI_UNKNOWN || v2 == elfcpp::EF_ARM_EABI_UNKNOWN)
> + || (v1 == elfcpp::EF_ARM_EABI_VER4 && v2 == elfcpp::EF_ARM_EABI_VER5)
> || (v1 == elfcpp::EF_ARM_EABI_VER5 && v2 == elfcpp::EF_ARM_EABI_VER4))
> return true;
>
This is OK.
Thanks.
Doug, since you offered, please go ahead and commit it.
Ian