This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gold][patch] Add a plugin callback for setting the extra search path

From: Cary Coutant <ccoutant at google dot com>
To: Rafael Espindola <espindola at google dot com>
Cc: Binutils <binutils at sourceware dot org>, Ian Lance Taylor <iant at google dot com>
Date: Mon, 21 Jun 2010 13:34:55 -0700
Subject: Re: [gold][patch] Add a plugin callback for setting the extra search path
References: <AANLkTildio1BtNdPhe-MAMox0CZtX8cTuHaIOBMuenDA@mail.gmail.com> <AANLkTinNDW6TolQMxJ-Hgo06jkyy_re8VLUx5XEXXmQN@mail.gmail.com> <AANLkTikFbCkhSPDlIZ35pw9-v60oLxS-p558fbfx9axm@mail.gmail.com>

> The attached patch includes the changes you asked for. The main reason
> why I moved find_file out of open was to use early return statements
> when we find the file.

OK.

+static bool
+find_file(const Dirsearch& dirpath, int *pindex,
+          const Input_file_argument* input_argument, bool *is_in_sysroot,
+          std::string *found_name, std::string *namep)

Space goes after the "*" for C++ code in gold (4x).

It looks good to me with that change.

-cary

References:
- [gold][patch] Add a plugin callback for setting the extra search path
  - From: Rafael Espindola
- Re: [gold][patch] Add a plugin callback for setting the extra search path
  - From: Cary Coutant
- Re: [gold][patch] Add a plugin callback for setting the extra search path
  - From: Rafael Espindola

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]