This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] don't generate long nops on i686 (only when -march=[intel])
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Kyle McMartin <kyle at mcmartin dot ca>
- Cc: binutils at sourceware dot org
- Date: Tue, 13 Jul 2010 06:33:07 -0700
- Subject: Re: [PATCH] don't generate long nops on i686 (only when -march=[intel])
- References: <20100713125902.GA10884@bombadil.infradead.org>
On Tue, Jul 13, 2010 at 5:59 AM, Kyle McMartin <kyle@mcmartin.ca> wrote:
> From: Kyle McMartin <kyle@redhat.com>
>
> Hi,
>
> In Fedora, glibc started building itself with -march=i686 flags to
> binutils as an "optimization." This exposes issues on the Geode, which
> is i686, but for long nops, since they are apparently not an architected
> part of the i686 ISA.
>
> Clarify this by only enabling long nops if we're generating 64-bit code
> (as far as I can tell, all x86_64 cpus support this) or explicitly
> generating code for the pentiumpro and above.
>
> Using this patch prevents people from overambitiously optimizing and
> breaking the Geode.
>
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
There is no ChangeLog. Please add CpuNop to i386-opc.h and use it
to determine when to generate nops.
Thanks.
--
H.J.