This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] elf directive parsing fix
- From: Alan Modra <amodra at gmail dot com>
- To: Rhonda Wittels <rhonda at codesourcery dot com>
- Cc: binutils at sourceware dot org
- Date: Thu, 15 Jul 2010 13:36:47 +0930
- Subject: Re: [patch] elf directive parsing fix
- References: <4C3DF608.2000007@codesourcery.com>
On Wed, Jul 14, 2010 at 01:38:16PM -0400, Rhonda Wittels wrote:
> * config/obj-elf.c (get_sym_from_input_line_and_check): New
> function to catch missing pseudo-op arguments.
> (obj_elf_local): Call new function.
> (obj_elf_weak): Likewise.
> (obj_elf_visibility): Likewise.
> (obj_elf_vtable_entry): Likewise.
> (obj_elf_type): Likewise.
>
> testsuite/
> * gas/elf/pseudo.s: New.
> * gas/elf/pseudo.l: New.
> * gas/elf/pseudo.d: New.
> * gas/elf/elf.exp: Run the new test.
Looks good except for some formatting errors.
> + /* There is no symbol name if input_line_pointer has not moved. */
> + if (name == input_line_pointer) {
> + as_bad (_("Missing symbol name in directive"));
> + }
No braces here.
> ! symbolP = get_sym_from_input_line_and_check();
Space before parenthesis. Another occurrence later too.
--
Alan Modra
Australia Development Lab, IBM