This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Support SHF_GNU_COMPRESSED


On Wed, Jul 21, 2010 at 7:21 AM, Alan Modra <amodra@gmail.com> wrote:
>
>> + ?/* The compressed size of the section in octets. ?*/
>> + ?bfd_size_type compressed_size;
>
> Seems to me this is unnecessary. ?For an input section, "rawsize"
> should be the on-disk size, with "size" that after decompression.
>

I tried it.  "rawsize" is used in various places like

sz = section->rawsize ? section->rawsize : section->size;
bfd_size_type amt = sec->rawsize > sec->size ? sec->rawsize : sec->size;

Record compressed in rawsize confuses BFD. I got failures like

../as-new  --32 --compress-debug-sections -o dump.o
/export/gnu/import/git/binutils-compress/gas/testsuite/gas/i386/dw2-compress-2.s
Executing on host: sh -c {../as-new  --32 --compress-debug-sections -o
dump.o /export/gnu/import/git/binutils-compress/gas/testsuite/gas/i386/dw2-compress-2.s
2>&1}  /dev/null gas.out (timeout = 300)
/export/build/gnu/binutils-compress/build-x86_64-linux/gas/testsuite/../../binutils/addr2line
 0x0 0x10 -e dump.o
Executing on host: sh -c
{/export/build/gnu/binutils-compress/build-x86_64-linux/gas/testsuite/../../binutils/addr2line
 0x0 0x10 -e dump.o >dump.out 2>gas.stderr}  /dev/null  (timeout =
300)
BFD: BFD (GNU Binutils) 2.20.51.20100721 internal error, aborting at
/export/gnu/import/git/binutils-compress/bfd/reloc.c line 5718 in
bfd_generic_get_relocated_section_contents

BFD: Please report this bug.

FAIL: DWARF2 debugging information 2


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]