This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] MIPS/BFD: Make RELA TLS relocs *not* partial_inplace
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: binutils at sourceware dot org
- Cc: Richard Sandiford <rdsandiford at googlemail dot com>, Catherine Moore <clm at codesourcery dot com>, gnu-mips-sgxx at codesourcery dot com
- Date: Mon, 26 Jul 2010 11:49:56 +0100 (BST)
- Subject: [PATCH] MIPS/BFD: Make RELA TLS relocs *not* partial_inplace
Hi,
RELA relocations do not store their addend (if any) in the relocatable
field. MIPS TLS relocs, however, have their partial_inplace attribute
set. I have searched past discussions around MIPS TLS support and failed
to find a singe justification for this oddity. Also other RELA platforms
have their TLS relocs' partial_inplace attribute clear. I have therefore
concluded this is a simple a copy & paste error and have fixed it with the
following change.
Regression-tested succesfully on mips-sde-elf and mips-linux-gnu targets.
2010-07-26 Maciej W. Rozycki <macro@codesourcery.com>
bfd/
* elf64-mips.c (mips_elf64_howto_table_rela)
[R_MIPS_TLS_DTPMOD64]: Clear partial_inplace.
[R_MIPS_TLS_DTPREL64, R_MIPS_TLS_GD, R_MIPS_TLS_LDM]: Likewise.
[R_MIPS_TLS_DTPREL_HI16, R_MIPS_TLS_DTPREL_LO16]: Likewise.
[R_MIPS_TLS_GOTTPREL, R_MIPS_TLS_TPREL64]: Likewise.
[R_MIPS_TLS_TPREL_HI16, R_MIPS_TLS_TPREL_LO16]: Likewise.
* elfn32-mips.c (elf_mips_howto_table_rela)
[R_MIPS_TLS_DTPMOD32]: Likewise.
[R_MIPS_TLS_DTPREL32, R_MIPS_TLS_GD, R_MIPS_TLS_LDM]: Likewise.
[R_MIPS_TLS_DTPREL_HI16, R_MIPS_TLS_DTPREL_LO16]: Likewise.
[R_MIPS_TLS_GOTTPREL, R_MIPS_TLS_TPREL32]: Likewise.
[R_MIPS_TLS_TPREL_HI16, R_MIPS_TLS_TPREL_LO16]: Likewise.
OK to apply?
Maciej
binutils-mips-rela.diff
Index: binutils-fsf-trunk-quilt/bfd/elf64-mips.c
===================================================================
--- binutils-fsf-trunk-quilt.orig/bfd/elf64-mips.c 2010-07-24 02:25:04.000000000 +0100
+++ binutils-fsf-trunk-quilt/bfd/elf64-mips.c 2010-07-24 02:25:13.000000000 +0100
@@ -1339,7 +1339,7 @@ static reloc_howto_type mips_elf64_howto
complain_overflow_dont, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_DTPMOD64", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
MINUS_ONE, /* src_mask */
MINUS_ONE, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1353,7 +1353,7 @@ static reloc_howto_type mips_elf64_howto
complain_overflow_dont, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_DTPREL64", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
MINUS_ONE, /* src_mask */
MINUS_ONE, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1368,7 +1368,7 @@ static reloc_howto_type mips_elf64_howto
complain_overflow_signed, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_GD", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
0x0000ffff, /* src_mask */
0x0000ffff, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1383,7 +1383,7 @@ static reloc_howto_type mips_elf64_howto
complain_overflow_signed, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_LDM", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
0x0000ffff, /* src_mask */
0x0000ffff, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1398,7 +1398,7 @@ static reloc_howto_type mips_elf64_howto
complain_overflow_signed, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_DTPREL_HI16", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
0x0000ffff, /* src_mask */
0x0000ffff, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1413,7 +1413,7 @@ static reloc_howto_type mips_elf64_howto
complain_overflow_signed, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_DTPREL_LO16", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
0x0000ffff, /* src_mask */
0x0000ffff, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1428,7 +1428,7 @@ static reloc_howto_type mips_elf64_howto
complain_overflow_signed, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_GOTTPREL", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
0x0000ffff, /* src_mask */
0x0000ffff, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1445,7 +1445,7 @@ static reloc_howto_type mips_elf64_howto
complain_overflow_dont, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_TPREL64", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
MINUS_ONE, /* src_mask */
MINUS_ONE, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1460,7 +1460,7 @@ static reloc_howto_type mips_elf64_howto
complain_overflow_signed, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_TPREL_HI16", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
0x0000ffff, /* src_mask */
0x0000ffff, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1475,7 +1475,7 @@ static reloc_howto_type mips_elf64_howto
complain_overflow_signed, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_TPREL_LO16", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
0x0000ffff, /* src_mask */
0x0000ffff, /* dst_mask */
FALSE), /* pcrel_offset */
Index: binutils-fsf-trunk-quilt/bfd/elfn32-mips.c
===================================================================
--- binutils-fsf-trunk-quilt.orig/bfd/elfn32-mips.c 2010-07-24 02:25:04.000000000 +0100
+++ binutils-fsf-trunk-quilt/bfd/elfn32-mips.c 2010-07-24 02:25:13.000000000 +0100
@@ -1301,7 +1301,7 @@ static reloc_howto_type elf_mips_howto_t
complain_overflow_dont, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_DTPMOD32", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
0xffffffff, /* src_mask */
0xffffffff, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1315,7 +1315,7 @@ static reloc_howto_type elf_mips_howto_t
complain_overflow_dont, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_DTPREL32", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
0xffffffff, /* src_mask */
0xffffffff, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1333,7 +1333,7 @@ static reloc_howto_type elf_mips_howto_t
complain_overflow_signed, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_GD", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
0x0000ffff, /* src_mask */
0x0000ffff, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1348,7 +1348,7 @@ static reloc_howto_type elf_mips_howto_t
complain_overflow_signed, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_LDM", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
0x0000ffff, /* src_mask */
0x0000ffff, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1363,7 +1363,7 @@ static reloc_howto_type elf_mips_howto_t
complain_overflow_signed, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_DTPREL_HI16", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
0x0000ffff, /* src_mask */
0x0000ffff, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1378,7 +1378,7 @@ static reloc_howto_type elf_mips_howto_t
complain_overflow_signed, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_DTPREL_LO16", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
0x0000ffff, /* src_mask */
0x0000ffff, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1393,7 +1393,7 @@ static reloc_howto_type elf_mips_howto_t
complain_overflow_signed, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_GOTTPREL", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
0x0000ffff, /* src_mask */
0x0000ffff, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1408,7 +1408,7 @@ static reloc_howto_type elf_mips_howto_t
complain_overflow_dont, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_TPREL32", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
0xffffffff, /* src_mask */
0xffffffff, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1425,7 +1425,7 @@ static reloc_howto_type elf_mips_howto_t
complain_overflow_signed, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_TPREL_HI16", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
0x0000ffff, /* src_mask */
0x0000ffff, /* dst_mask */
FALSE), /* pcrel_offset */
@@ -1440,7 +1440,7 @@ static reloc_howto_type elf_mips_howto_t
complain_overflow_signed, /* complain_on_overflow */
_bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_TLS_TPREL_LO16", /* name */
- TRUE, /* partial_inplace */
+ FALSE, /* partial_inplace */
0x0000ffff, /* src_mask */
0x0000ffff, /* dst_mask */
FALSE), /* pcrel_offset */