This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Make --start-lib/--end-lib block on previous add symbols tasks


>> Ian or Cary, could one of you submit this for me?? I don't have CVS write
>> access.
>
> Hmmm, with Neil's patch applied to my sources, my test case is still
> running the tasks out of order. Investigating...
>
> (There was a typo in testsuite/Makefile.am -- should have been
> libstart_lib_test.a instead of lib_start_lib_test.a -- but I fixed
> that and it's still failing.)

Oops, also forgot the -Bgcctestdir/ on the link command in the new test case.

Fixed and committed. The patch as committed is attached.

-cary


2010-08-19  Neil Vachharajani  <nvachhar@google.com>
            Cary Coutant  <ccoutant@google.com>

        * gold/archive.h (Add_lib_group_symbols): Add readsyms_blocker_, adjust
        constructor, and set_blocker.
        * gold/archive.cc (Add_lib_group_symbols::is_runnable): Also check
        readsyms_blocker_.
        * gold/readsyms.cc (Read_symbols::do_lib_group): Also pass
        this->this_blocker_ to Add_lib_group_symbols::set_blocker.
        * testsuite/Makefile.am (start_lib_test): New test case.
        * testsuite/Makefile.in: Regenerate.
        * testsuite/start_lib_test_main.c: New file.
        * testsuite/start_lib_test_1.c: New file.
        * testsuite/start_lib_test_2.c: New file.
        * testsuite/start_lib_test_3.c: New file.

Attachment: gold-start-lib-patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]