This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gold patch] Fix internal error with --start-lib and object file with no global syms

From: Cary Coutant <ccoutant at google dot com>
To: Ian Lance Taylor <iant at google dot com>
Cc: Binutils <binutils at sourceware dot org>
Date: Mon, 23 Aug 2010 13:30:04 -0700
Subject: Re: [gold patch] Fix internal error with --start-lib and object file with no global syms
References: <AANLkTimRi6BtdbE0r1au7v077HTMmC5TAfN73PB3cGuT@mail.gmail.com> <mcrr5hpw3at.fsf@google.com>

>> ? ? ? ? * archive.cc (Lib_group::add_symbols): Lock object before deleting its
>> ? ? ? ? symbols data.
>> ? ? ? ? (Lib_group::include_member): Unlock object after deleting its
>> ? ? ? ? symbols data.
>> ? ? ? ? * testsuite/start_lib_test_3.c: Remove all global symbols to trigger
>> ? ? ? ? the bug fixed here.

> Remove space before left parenthesis in gold_assert line.
>
> This is OK with that change.

Thanks, committed.

-cary

References:
- [gold patch] Fix internal error with --start-lib and object file with no global syms
  - From: Cary Coutant
- Re: [gold patch] Fix internal error with --start-lib and object file with no global syms
  - From: Ian Lance Taylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]