Re: PATCH: ld/11944: elf_object_id (abfd) == elf_hash_table_id (htab) dosn't work on all targets

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Wed, Aug 25, 2010 at 6:54 AM, Maciej W. Rozycki <macro@linux-mips.org> wrote:
> On Wed, 25 Aug 2010, H.J. Lu wrote:
>
>> > ? ? ? ?* elf64-mips.c (ELF_TARGET_ID): New.
> [...]
>> > ? ? ? ?* elfn32-mips.c (ELF_TARGET_ID): New.
> [...]
>> I will check it to fix many ELF targets if there are no objections.
>
> ?No opinion as to the update itself, but changes corresponding to the
> ChangeLog entries above are missing from your patch.
>
> ?Also elfxx-mips.h might be the right place to put macro definitions
> shared across all the MIPS ELF variants; just a side note -- not that you
> should be doing that with your proposed change.
>
> ?Maciej
>

Here is the updated patch with MIPS changes.


-- 
H.J.

Attachment: binutils-pr11944-2.patch
Description: Text document