This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR gold/11996: Gold failed to build with gcc 4.2.4
- From: Ian Lance Taylor <iant at google dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Thu, 09 Sep 2010 12:40:03 -0700
- Subject: Re: PATCH: PR gold/11996: Gold failed to build with gcc 4.2.4
- References: <20100909175634.GA27969@intel.com>
"H.J. Lu" <hongjiu.lu@intel.com> writes:
> 2010-09-09 H.J. Lu <hongjiu.lu@intel.com>
>
> PR gold/11996
> * object.cc (Sized_relobj::do_finalize_local_symbols): Remove
> "This::" to work around a bug in gcc 4.2.
>
> * testsuite/ifuncmain7.c (foo_ifunc): Add __attribute__ ((used)).
> - This::Compute_final_local_value_status cflv_status =
> + // Remove "This::" to work around a bug in gcc 4.2.
> + Compute_final_local_value_status cflv_status =
> this->compute_final_local_value_internal(i, lv, lv, relocatable,
> out_sections, out_offsets,
> symtab);
The comment is not useful as is. Please omit it.
This is OK with that change.
Thanks.
Ian