This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch gas/testsuite SEH x64]: Some initial tests about SEH pseudo-operators
- From: Dave Korn <dave dot korn dot cygwin at gmail dot com>
- To: Kai Tietz <ktietz70 at googlemail dot com>
- Cc: Binutils <binutils at sourceware dot org>, Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- Date: Sun, 12 Sep 2010 16:32:52 +0100
- Subject: Re: [patch gas/testsuite SEH x64]: Some initial tests about SEH pseudo-operators
- References: <AANLkTi=U8okhE9k1=Q47yAgqCLQpeQFXhMpgzSA8j6a8@mail.gmail.com>
On 12/09/2010 10:43, Kai Tietz wrote:
> Hello,
>
> this patch adds some x64 SEH related tests to gas' testsuite.
Thank you! Even these kinds of trivial smoke-tests are worthwhile.
> ChangeLog
>
> 2010-09-12 Kai Tietz
>
> * /gas/pe/pe_seh.exp: New.
> * /gas/pe/peseh-x64.s: New.
> * /gas/pe/peseh-x64.d: New.
> * /gas/pe/peseh-x64-2.s: New.
> * /gas/pe/peseh-x64-2.d: New.
> * /gas/pe/peseh-x64-3.s: New.
> * /gas/pe/peseh-x64-3.d: New.
>
> Tested for x86_64-w64-mingw32 and for i686-pc-cygwin. Ok for apply?
Please let's not multiply expect scripts unnecessarily. I can't think of
any reason not to just tag the "if ([istarget "x86_64-*-mingw*"])" clause onto
the end of the existing gas/pe/pe.exp, so OK with that change. Also, don't
forget to remove those leading slashes from the filenames in your changelog
entry when you check it in.
cheers,
DaveK