This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch pe-coff]: Fix output of debug sections in image
- From: Richard Henderson <rth at redhat dot com>
- To: Kai Tietz <ktietz70 at googlemail dot com>
- Cc: Binutils <binutils at sourceware dot org>, Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- Date: Mon, 20 Sep 2010 13:24:55 -0700
- Subject: Re: [patch pe-coff]: Fix output of debug sections in image
- References: <AANLkTi=47S9Ty9UGZmXUWcoT7KCc7jbg8JTKJi1Ymd=n@mail.gmail.com>
On 09/20/2010 12:33 PM, Kai Tietz wrote:
> Hello,
>
> this patch fixes the output of debugging sections in PE-image.
>
> ChangeLog bfd
>
> * coffcode.h (sec_to_styp_flags): Adjust debug
> sections to be conform to pe-coff specification
> and avoid marking them as excluded.
> (styp_to_sec_flags): Doing reverse mapping.
>
> ChangeLog ld
>
> * ldlang.c (lang_add_section): Allow for debugging
> section to be marked as noload but to keep content.
> (IGNORE_SECTION): Likewise.
> (lang_check_section_addresses): Likewise.
> * ldwrite.c (build_link_order): Likewise.
>
> Tested for x86_64-w64-mingw32, i686-w64-mingw32, and i686-pc-cygwin.
> Ok for apply?
I do wonder if the SEC_NEVER_LOAD bits can simply be
removed, similar to what Alan did recently for ELF.
Otherwise it looks like improvement.
I'd like someone else to look at this too, though.
r~