This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Add plugin interface to LD [4/4] Add files, libs and dir paths.
- From: Dave Korn <dave dot korn dot cygwin at gmail dot com>
- To: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Fri, 24 Sep 2010 01:58:14 +0100
- Subject: Re: [PATCH] Add plugin interface to LD [4/4] Add files, libs and dir paths.
- References: <4C9AE5CA.80707@gmail.com> <4C9AE65D.5000201@gmail.com>
On 23/09/2010 06:32, Dave Korn wrote:
Spot of self-review here:
> --- a/ld/ldmain.c
> +++ b/ld/ldmain.c
> @@ -889,7 +889,7 @@ add_archive_element (struct bfd_link_info *info,
> multiple times. */
>
> static bfd_boolean
> -multiple_definition (struct bfd_link_info *info ATTRIBUTE_UNUSED,
> +multiple_definition (struct bfd_link_info *info,
> const char *name,
> bfd *obfd,
> asection *osec,
Don't do that, because it's only used when ENABLE_PLUGINS. Will remember
not to commit with this change.
cheers,
DaveK