This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: C6x gas fix for GOT relocs


On Mon, 27 Sep 2010, Bernd Schmidt wrote:

> On 09/23/2010 08:56 PM, Joseph S. Myers wrote:
> > On Thu, 23 Sep 2010, Bernd Schmidt wrote:
> > 
> >> Here's a patch that adds a tic6x_fix_adjustable function to the C6x
> >> assembler. Like in several other targets, we must prevent the assembler
> >> from creating GOT relocs with an offset, e.g. for "const.str.1.1 + n",
> >> rather than just for a symbol. Strictly speaking this isn't necessary
> >> just yet as the linker has no support for these relocs, but I'm working
> >> on that.
> >>
> >> Is the patch ok?  Does it need an extra assembler testcase?  This
> >> failure shows up numerous times in the gcc testsuite.
> > 
> > Adding this for the GOT relocations is OK; there should be an assembler 
> > test added covering each of the affected relocations.
> 
> Like this?

OK with the test #name changed from "GOT relocs" to "C6X GOT relocs" or 
similar.  Test names form a global namespace for the whole assembler 
testsuite (appearing after PASS: or FAIL: in the .sum file) so I think 
it's best for target-specific tests to have unambiguously target-specific 
names (and all the C6X assembler and linker tests do have such names).

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]