This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: Clear non_elf on _GLOBAL_OFFSET_TABLE_
- From: Alan Modra <amodra at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Fri, 1 Oct 2010 12:50:43 +0930
- Subject: Re: PATCH: Clear non_elf on _GLOBAL_OFFSET_TABLE_
- References: <20100924052736.GA15942@intel.com> <20100924122815.GO16376@bubble.grove.modra.org> <AANLkTikGUC27dbjf7d=e6HCvDfXqk6h5niNREoXA_PPO@mail.gmail.com>
On Thu, Sep 30, 2010 at 07:02:58PM -0700, H.J. Lu wrote:
> On Fri, Sep 24, 2010 at 5:28 AM, Alan Modra <amodra@gmail.com> wrote:
> > On Thu, Sep 23, 2010 at 10:27:36PM -0700, H.J. Lu wrote:
> >> This patch clears non_elf on _GLOBAL_OFFSET_TABLE_
> >
> > To stop _bfd_elf_fix_symbol_flags non_elf code?
> >
> Yes, it has
[snip]
OK, then you should probably do this in _bfd_elf_define_linkage_sym.
That way you'll treat _DYNAMIC and _PROCEDURE_LINKAGE_TABLE_ the same
as _GLOBAL_OFFSET_TABLE_, and you'll also fix _GLOBAL_OFFSET_TABLE_
for other targets. Please do run the testsuite for affected targets
(grep _bfd_elf_define_linkage_sym bfd/*.c) to check for regressions
before committing this change.
--
Alan Modra
Australia Development Lab, IBM