Re: [PATCH,take3] Add plugin interface to LD, respun. [1..6/6]

[Richard Henderson <rth at redhat dot com>]

On 10/12/2010 09:22 PM, Dave Korn wrote:
> ... this turns out not to be to do with pic in libiberty or runpaths or
> anything like that at all.  It happens whenever you run "make check", but not
> if you run "make check RUNTESTFLAGS=plugin.exp" (I was leaving comparing full
> testsuite before-and-after runs for last thing, which is why I only just had
> it now).  This is because I used a variable named "nm_output" and it's
> clashing in some way with the identically-named variable in ld_compile,
> depending which order things get run and hence defined in, so I cut through
> the whole mess and renamed it.  (It seems you're not allowed to have
> identically-named local variables in separate enclosing scopes in tcl, iiuc.)

*shudder* I knew I hated tcl.

Re %p downthread, I agree that's the best solution.

Regarding the actual patch commit, I don't think it's worth keeping
the patches separate.  You can commit them in one go if you like.

Patches ok.


r~