This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [MIPS] Change madd/maddu/msub/msubu/mult/multu to DSP rev1
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "Fu\, Chao-Ying" <fu at mips dot com>
- Cc: "binutils\ at sourceware dot org" <binutils at sourceware dot org>, "Lau\, David" <davidlau at mips dot com>
- Date: Sat, 23 Oct 2010 09:21:34 +0100
- Subject: Re: [MIPS] Change madd/maddu/msub/msubu/mult/multu to DSP rev1
- References: <7C6479EB2BF52547AC332FD6034646DA3017DE6E@exchdb02.mips.com>
"Fu, Chao-Ying" <fu@mips.com> writes:
> Opcodes/ChangeLog
> 2010-10-20 Chao-ying Fu <fu@mips.com>
>
> * mips-opc.c (madd, maddu, msub, msubu, mult, multu): Change D33 to D32.
>
> Gas/testsuite/ChangeLog
> 2010-10-20 Chao-ying Fu <fu@mips.com>
>
> * gas/mips/mips32-dsp.d, gas/mips/mips32-dsp.s: Add madd, maddu, msub, msubu, mult, multu.
Nit: last changelog line needs to be wrapped to 80 chars. Otherwise OK,
thanks.
For the record, I did wonder whether we should also remove the corresponding
tests from mips-dspr2.s, since other rev1 stuff isn't tested in mips-dspr2.s.
I agree it's better to leave them though, so that we have both classifications
covered.
Richard