This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 15/15] MIPS/GAS/test: Cover SD, L.D, S.D, LDC1 and SDC1


On Sun, 10 Oct 2010, Richard Sandiford wrote:

> > 	gas/testsuite/
> > 	* gas/mips/ld.s: Adjust to let SD, L.D, S.D, LDC1 and SDC1
> > 	macros to be tested, according to the "tsd", "tl_d", "ts_d",
> > 	"tldc1" and "tsdc1" symbols.
> > 	* gas/mips/sd.d: New test.
> > 	* gas/mips/ecoff@sd.d: Likewise, ECOFF version.
> > 	* gas/mips/mips1@ecoff@sd.d: Likewise, MIPS I/ECOFF version.
> > 	* gas/mips/r3000@ecoff@sd.d: Likewise, R3000/ECOFF version.
> > 	* gas/mips/r3900@ecoff@sd.d: Likewise, R3900/ECOFF version.
> > 	* gas/mips/mips2@ecoff@sd.d: Likewise, MIPS II/ECOFF version.
> > 	* gas/mips/mips32@ecoff@sd.d: Likewise, MIPS32/ECOFF version.
> > 	* gas/mips/mips32r2@ecoff@sd.d: Likewise, MIPS32r2/ECOFF
> > 	version.
> > 	* gas/mips/sd-f.d: New test.
> > 	* gas/mips/ecoff@sd-f.d: Likewise, ECOFF version.
> > 	* gas/mips/mips1@ecoff@sd-f.d: Likewise, MIPS I/ECOFF version.
> > 	* gas/mips/r3000@ecoff@sd-f.d: Likewise, R3000/ECOFF version.
> > 	* gas/mips/r3900@ecoff@sd-f.d: Likewise, R3900/ECOFF version.
> > 	* gas/mips/mips2@ecoff@sd-f.d: Likewise, MIPS II/ECOFF version.
> > 	* gas/mips/mips32@ecoff@sd-f.d: Likewise, MIPS32/ECOFF version.
> > 	* gas/mips/mips32r2@ecoff@sd-f.d: Likewise, MIPS32r2/ECOFF
> > 	version.
> > 	* gas/mips/l_d.d: New test.
> > 	* gas/mips/mips1@l_d.d: Likewise, MIPS I version.
> > 	* gas/mips/r3000@l_d.d: Likewise, R3000 version.
> > 	* gas/mips/r3900@l_d.d: Likewise, R3900 version.
> > 	* gas/mips/l_d-f.d: New test.
> > 	* gas/mips/mips1@l_d-f.d: Likewise, MIPS I version.
> > 	* gas/mips/r3000@l_d-f.d: Likewise, R3000 version.
> > 	* gas/mips/r3900@l_d-f.d: Likewise, R3900 version.
> > 	* gas/mips/s_d.d: New test.
> > 	* gas/mips/mips1@s_d.d: Likewise, MIPS I version.
> > 	* gas/mips/r3000@s_d.d: Likewise, R3000 version.
> > 	* gas/mips/r3900@s_d.d: Likewise, R3900 version.
> > 	* gas/mips/s_d-f.d: New test.
> > 	* gas/mips/mips1@s_d-f.d: Likewise, MIPS I version.
> > 	* gas/mips/r3000@s_d-f.d: Likewise, R3000 version.
> > 	* gas/mips/r3900@s_d-f.d: Likewise, R3900 version.
> > 	* gas/mips/ldc1.d: New test.
> > 	* gas/mips/ldc1-f.d: Likewise.
> > 	* gas/mips/sdc1.d: Likewise.
> > 	* gas/mips/sdc1-f.d: Likewise.
> > 	* gas/mips/sd-n32.d: Likewise.
> > 	* gas/mips/sd-n64.d: Likewise.
> > 	* gas/mips/sd-f-n32.d: Likewise.
> > 	* gas/mips/sd-f-n64.d: Likewise.
> > 	* gas/mips/l_d-n32.d: Likewise.
> > 	* gas/mips/l_d-n64.d: Likewise.
> > 	* gas/mips/l_d-f-n32.d: Likewise.
> > 	* gas/mips/l_d-f-n64.d: Likewise.
> > 	* gas/mips/s_d-n32.d: Likewise.
> > 	* gas/mips/s_d-n64.d: Likewise.
> > 	* gas/mips/s_d-f-n32.d: Likewise.
> > 	* gas/mips/s_d-f-n64.d: Likewise.
> > 	* gas/mips/ldc1-n32.d: Likewise.
> > 	* gas/mips/ldc1-n64.d: Likewise.
> > 	* gas/mips/ldc1-f-n32.d: Likewise.
> > 	* gas/mips/ldc1-f-n64.d: Likewise.
> > 	* gas/mips/sdc1-n32.d: Likewise.
> > 	* gas/mips/sdc1-n64.d: Likewise.
> > 	* gas/mips/sdc1-f-n32.d: Likewise.
> > 	* gas/mips/sdc1-f-n64.d: Likewise.
> > 	* gas/mips/mips.exp: Run the new tests.
> 
> OK, thanks.  The number of combinations and files is becoming a bit
> daunting, but that's the nature of the beast that is MIPS.  I agree
> all these things should be tested.

 That's still far from complete coverage, but will at least test a 
reasonable subset with these changes.  We can see how things need to be 
addressed as we discover them.  Applied, finally.  Thanks.

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]