Re: [PATCH] fix testsuite ldscripts problem

[Dave Korn <dave dot korn dot cygwin at gmail dot com>]

On 27/10/2010 19:22, Ralf Wildenhues wrote:
> * Dave Korn wrote on Wed, Oct 27, 2010 at 01:37:26AM CEST:
>> On 26/10/2010 21:22, Ralf Wildenhues wrote:
>>> * Dave Korn wrote on Mon, Oct 25, 2010 at 10:23:18PM CEST:
>>>> -check-DEJAGNU: site.exp
>>>> +ldscripts-link:
>>>> +	-eval "x`$(LIBTOOL) --config | $(GREP) ^objdir=`" && \
> 
> By the way, *really* old shells interpret unquoted ^ as synonym to |
> (single quotes are safe here around ^objdir=, unlike double quotes).

  Thanks Ralf, I was hoping you'd show up with advice :)  I'll change as you
advise; as far as I know, it's only DOS that has a different objdir from
.libs, and that's exactly also where '^' is a line continuation....

>>>> +	if test -d $$xobjdir; then \
>>>> +	    test ! -e $$xobjdir/ldscripts \
>>>> +		&& $(LN_S) ../ldscripts $$xobjdir/ldscripts; \
> 
>>> Besides, Solaris /bin/sh test does not have -e, so you might want to
>>> prefer -f or -r if you're still going to use the test.
>>   Surely -f isn't right?  I think that checks for a regular file, and I do not
>> know whether a link would necessarily count as one.
> 
> If the link points to a regular file, then yes.

  Actually it points to a directory, so perhaps not?

> Since you link to a directory (sorry for not realizing this sooner),

  Heh!

> $(LN_S) won't work anyway if it's not 'ln -s', so at that point you'd
> probably have to mkdir and cp -p or cp -R anyway.  test -d should
> otherwise work also for symlinks to directories.

  I thought the whole point of $(LN_S) was that it would turn into a copy on
platforms like mingw?

    cheers,
      DaveK