Re: [patch binutils/11065] [DllTool] DLL name from DEF file is ignored when using --output-exp option

[Kai Tietz <Kai dot Tietz at onevision dot com>]

binutils-owner@sourceware.org wrote on 23.11.2010 15:19:40:

> Hello,
> 
> this patch addresses the bug described at 
> http://sourceware.org/bugzilla/show_bug.cgi?id=11065 report. The logic 
> should be IMHO that if --dllname is specified, it shall be used in any 
> case. If the exp_name is used for determine the DLL name, then just in 
> case there is no DLL name specified in the .def file.
> 
> ChangeLog
> 
> 2010-11-23  Kai Tietz
> 
>         PR binutils/11065
>         * dlltool.c (dll_name_set_by_exp_name): New variable.
>         (def_name): Allow setting of dll_name by .def file.
>         (def_library): Likewise.
>         (main): Set dll_name_set_by_exp_name, if dll_name is
>         set indirect by exp_name.
> 
> Tested for x86_64-w64-mingw32, i686-pc-cygwin, and i686-w64-mingw32. Ok 
> for apply?

Corrected in patch a potential wrong call of free to none-allocated 
memory. So dll_name can't be free'ed and is just set unconditional to NULL 
in case of a dll-name specified via .def file.

Kai

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

Attachment: dlltool_11065.diff
Description: Binary data