This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 08/20] MIPS/GAS: Improve a LUI complaint message
- From: Paul Koning <paul_koning at dell dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: binutils at sourceware dot org
- Date: Thu, 2 Dec 2010 14:21:57 -0500
- Subject: Re: [PATCH 08/20] MIPS/GAS: Improve a LUI complaint message
- References: <alpine.DEB.1.10.1012020105230.14129@tp.orcam.me.uk>
On Dec 2, 2010, at 2:19 PM, Maciej W. Rozycki wrote:
> Hi,
>
> This change makes a LUI complaint message in mips_ip() report the
> value complained about and resemble English a bit more too.
>
> 2010-12-02 Maciej W. Rozycki <macro@codesourcery.com>
>
> gas/
> * config/tc-mips.c (mips_ip)['u']: Report the value of the LUI
> argument complained about; reword the message.
>
> OK to apply?
>
> Maciej
>
> binutils-gas-mips-msg-lui.diff
> Index: binutils-fsf-trunk-quilt/gas/config/tc-mips.c
> ===================================================================
> --- binutils-fsf-trunk-quilt.orig/gas/config/tc-mips.c 2010-12-01 21:05:50.000000000 +0000
> +++ binutils-fsf-trunk-quilt/gas/config/tc-mips.c 2010-12-01 21:05:50.000000000 +0000
> @@ -10005,7 +10005,8 @@ mips_ip (char *str, struct mips_cl_insn
> && imm_expr.X_op == O_constant
> && (imm_expr.X_add_number < 0
> || imm_expr.X_add_number >= 0x10000))
> - as_bad (_("LUI expression not in range 0..65535"));
> + as_bad (_("LUI expression (%lu) not in 0..65535 range"),
> + (unsigned long) imm_expr.X_add_number);
> s = expr_end;
> continue;
>
I'm not a native speaker of English, but the original word order (...in range x..y) seems better to me.
paul