This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 04/20] MIPS/GAS: Spell out 0 referring to $0 as ZERO


On Thu, 2 Dec 2010, Paul Koning wrote:

> > Here is a (supposedly) exhaustive change to macro() that makes $0 
> > register references in macro_build() and move_register() calls to be 
> > spelled as ZERO for better clarity and difference to places where an 
> > immediate value of 0 is referred to.  I have not changed other places, 
> > typically pieces of code like:
> > 
> >  treg = 0;
> > 
> > or:
> > 
> >  if (sreg == 0)
> > 
> > whose reference to $0 is obvious.
> 
> I wouldn't say those are a whole lot more obvious than the ones you did 
> change...

 These variables refer to registers and their names make it unambiguous, 
but feel free to propose a follow-on patch -- I won't object such a 
change.

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]