This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Thu, Dec 2, 2010 at 5:54 AM, Richard Sandiford <rdsandiford@googlemail.com> wrote: > Mingming Sun <mingm.sun@gmail.com> writes: >> Index: opcodes/mips-opc.c >> =================================================================== >> RCS file: /cvs/src/src/opcodes/mips-opc.c,v >> retrieving revision 1.82 >> diff -u -p -r1.82 mips-opc.c >> --- opcodes/mips-opc.c ? ? ? ?11 Nov 2010 10:23:39 -0000 ? ? ?1.82 >> +++ opcodes/mips-opc.c ? ? ? ?1 Dec 2010 02:54:33 -0000 >> @@ -1838,28 +1838,40 @@ const struct mips_opcode mips_builtin_op >> ?/* ST Microelectronics Loongson-2E and -2F. ?*/ >> ?{"mult.g", ? "d,s,t", ? ? ? ?0x7c000018, ? ? 0xfc0007ff, ? ? RD_s|RD_t|WR_d, 0, ? ? ?IL2E ? ?}, >> ?{"mult.g", ? "d,s,t", ? ? ? ?0x70000010, ? ? 0xfc0007ff, ? ? RD_s|RD_t|WR_d, 0, ? ? ?IL2F ? ?}, >> +{"gsmult", ? "d,s,t", ? ? ? ?0x70000010, ? ? 0xfc0007ff, ? ? WR_d|RD_s|RD_t, 0, ? ? ?IL3A ? ?}, >> ?{"multu.g", ?"d,s,t", ? ? ? ?0x7c000019, ? ? 0xfc0007ff, ? ? RD_s|RD_t|WR_d, 0, ? ? ?IL2E ? ?}, >> ?{"multu.g", ?"d,s,t", ? ? ? ?0x70000012, ? ? 0xfc0007ff, ? ? RD_s|RD_t|WR_d, 0, ? ? ?IL2F ? ?}, > > [...] > > I can see why you listed the read and write flags in the same order as the > operands, but please follow the existing order (RD_s|RD_t|WR_d) instead. > Consistency is more important than logic here :-) ?Same goes for the > other instructions. > > The patch is otherwise OK as far as it goes, but I'm afraid even this > change needs a test in the gas testsuite. > > Richard > Thanks, Richard. This new patch changes the read and write order of the pinfo. Also a testsuite is added. Thanks, Mingming Sun 2010-12-03 Mingming Sun <mingm.sun@gmail.com> opcodes/ * mips-opc.c: (mips_builtin_opcodes): Add loongson3a mul/div and fixed point instructions. gas/testsuite/ * gas/mips/loongson-3a.s, gas/mips/loongson-3a.d: New test. * gas/mips/mips.exp: Run it.
Attachment:
new-patch.txt
Description: Text document
Attachment:
loongson-3a.s
Description: Binary data
Attachment:
loongson-3a.d
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |