This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PATCH: Don't pass -fvtable-gc to GCC 3.4.0 or above
- From: "H.J. Lu" <hongjiu dot lu at intel dot com>
- To: binutils at sourceware dot org
- Date: Sat, 4 Dec 2010 10:35:27 -0800
- Subject: PATCH: Don't pass -fvtable-gc to GCC 3.4.0 or above
- Reply-to: "H.J. Lu" <hjl dot tools at gmail dot com>
Hi.
Starting with 3.4.0, -fvtable-gc is no longer supported. We used to
prune GCC warnings. Due to
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46802
Pruning no longer works with GCC 4.6. There is no point to pass
-fvtable-gc to GCC 3.4.0 or above. I checked in this patch to work
around the GCC change.
H.J.
---
diff --git a/ld/testsuite/ChangeLog b/ld/testsuite/ChangeLog
index 23b31e6..f0d81d3 100644
--- a/ld/testsuite/ChangeLog
+++ b/ld/testsuite/ChangeLog
@@ -1,5 +1,10 @@
2010-12-04 H.J. Lu <hongjiu.lu@intel.com>
+ * ld-selective/selective.exp: Don't pass -fvtable-gc to GCC
+ 3.4.0 or above.
+
+2010-12-04 H.J. Lu <hongjiu.lu@intel.com>
+
* ld-elfvers/vers.exp: Replace -export-dynamic with
-Wl,-export-dynamic.
diff --git a/ld/testsuite/ld-selective/selective.exp b/ld/testsuite/ld-selective/selective.exp
index b563d35..81870c2 100644
--- a/ld/testsuite/ld-selective/selective.exp
+++ b/ld/testsuite/ld-selective/selective.exp
@@ -60,7 +60,7 @@ set seltests {
}
set cflags "-w -O -ffunction-sections -fdata-sections"
-set cxxflags "-fvtable-gc -fno-exceptions -fno-rtti"
+set cxxflags "-fno-exceptions -fno-rtti"
set ldflags "--gc-sections -Bstatic"
if [istarget mips*-*] {
@@ -106,14 +106,16 @@ foreach testitem $seltests {
# It's either C or C++ at the moment.
if { $testtype == "C++" } {
- set testflags "$cflags $cxxflags"
set compiler "$CXX"
# Starting with 3.4.0, -fvtable-gc is no longer supported and thus
# the functionality we try to test for cannot be expected to work.
set version [remote_exec host "$CXX -dumpversion"]
set version [lindex $version 1]
if [regexp "^(\[1-9\]\[0-9\]+|\[4-9\]|3.(\[1-9\]\[0-9\]+|\[4-9\]))\\." $version] {
+ set testflags "$cflags $cxxflags"
setup_xfail {*-*-*}
+ } else {
+ set testflags "$cflags $cxxflags -fvtable-gc"
}
} else {
set testflags "$cflags"