This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PATCH: PR ld/12288: No newline at the end of diagnostic messages
- From: "H.J. Lu" <hongjiu dot lu at intel dot com>
- To: binutils at sourceware dot org
- Date: Sun, 5 Dec 2010 17:00:51 -0800
- Subject: PATCH: PR ld/12288: No newline at the end of diagnostic messages
- Reply-to: "H.J. Lu" <hjl dot tools at gmail dot com>
Hi,
The plugin diagnostic text doesn't have the trailing `\n'. I checked in
this patch to add the trailing `\n' similar to gold.
H.J.
---
diff --git a/ld/ChangeLog b/ld/ChangeLog
index bb7b5a6..4aed58c 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,5 +1,10 @@
2010-12-05 H.J. Lu <hongjiu.lu@intel.com>
+ PR ld/12288
+ * plugin.c (message): Add the trailing `\n'.
+
+2010-12-05 H.J. Lu <hongjiu.lu@intel.com>
+
* ldfile.c (ldfile_open_file_search): Check maybe_archive instead
of is_archive.
* emultempl/aix.em: Likewise.
diff --git a/ld/plugin.c b/ld/plugin.c
index ae9c378..10e9973 100644
--- a/ld/plugin.c
+++ b/ld/plugin.c
@@ -587,13 +587,15 @@ message (int level, const char *format, ...)
case LDPL_ERROR:
default:
{
- char *newfmt = ACONCAT ((level == LDPL_FATAL ? "%F" : "%X",
- format, NULL));
+ char *newfmt = ACONCAT ((level == LDPL_FATAL ? "%P%F:" : "%P%X:",
+ format, "\n", NULL));
vfinfo (stderr, newfmt, args, TRUE);
}
break;
}
+ fputc('\n', stderr);
+
va_end (args);
return LDPS_OK;
}