This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold patch] Add warning for executable stacks
- From: Ian Lance Taylor <iant at google dot com>
- To: Cary Coutant <ccoutant at google dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Thu, 09 Dec 2010 15:09:39 -0800
- Subject: Re: [gold patch] Add warning for executable stacks
- References: <AANLkTin8GjK4GMkmX=Ni1DW1K-0HGY+XkscAy3Jw6mXZ@mail.gmail.com>
Cary Coutant <ccoutant@google.com> writes:
> * layout.cc (Layout::layout_gnu_stack): Add warnings for executable
> stack.
> * layout.h (Layout::layout_gnu_stack): Add pointer to Object
> parameter; change all callers.
> * object.cc (Sized_relobj::do_layout): Adjust call to layout_gnu_stack.
> * options.h (warn_execstack): New option.
> if (!seen_gnu_stack)
> - this->input_without_gnu_stack_note_ = true;
> + {
> + this->input_without_gnu_stack_note_ = true;
> + if (parameters->options().warn_execstack()
> + && parameters->target().is_default_stack_executable())
> + gold_warning(_("%s: missing .note.GNU-stack section"),
> + obj->name().c_str());
> + }
Please make this message
%s: missing .note.GNU-stack section implies executable stack
This is OK with that change.
Thanks.
Ian