Re: [PATCH 20/20] MIPS/GAS: Remove dead format specifier code

["Maciej W. Rozycki" <macro at codesourcery dot com>]

On Tue, 7 Dec 2010, Richard Sandiford wrote:

> > 	gas/
> > 	* config/tc-mips.c (mips_ip): Remove dead format specifier code.
> 
> OK, thanks.  I wonder if the 'G' confusion came from someone misinterpreting:
> 
> 	      if (ok) 
> 		{
> 		  lastregno = regno;
> 		  continue;
> 		}
> 	      else
> 		break;
> 
> as fallthrough?

 Yes, this well could be indeed, good point.  I haven't thought about this 
arrangement being a possible cause.

 Another possibility is simply a remnant from before cooked CP0 register 
names were introduced -- I would expect 'G' to have been handled like 'd' 
back then without dedicated outermost switch statement's case code.

> 	      if (ok) 
> 		{
> 		  lastregno = regno;
> 		  continue;
> 		}
> 	      break;
> 
> would be more usual.  Maybe I'll tweak it after the microMIPS stuff
> has gone in.

 Well, I have actually removed the oddity with the microMIPS patch as the 
case had to be heavily tweaked anyway.  I also removed a couple of similar 
oddities, where a "break" or "continue" was included at the end in a block 
rather than following it within the microMIPS patch itself, but I have 
just noticed a couple escaped me.  I'll clean them up as well as they may 
make one wonder if the closing brace is the end of a (misindented) 
compound selection or iteration statement.

  Maciej