This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][PR ld/10144] MIPS/BFD: Don't make debug section relocs dynamic
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: Alan Modra <amodra at gmail dot com>, binutils at sourceware dot org
- Date: Sat, 11 Dec 2010 10:21:29 +0000
- Subject: Re: [PATCH][PR ld/10144] MIPS/BFD: Don't make debug section relocs dynamic
- References: <alpine.DEB.1.10.1009150019500.25860@tp.orcam.me.uk> <87wrqj30mu.fsf@firetop.home> <alpine.DEB.1.10.1009182329210.25860@tp.orcam.me.uk> <g4oca5yp5u.fsf@richards-desktop.stglab.manchester.uk.ibm.com> <g4zktht7yn.fsf@richards-desktop.stglab.manchester.uk.ibm.com> <alpine.DEB.1.10.1011101722430.5156@tp.orcam.me.uk> <g4vd44tbkn.fsf@richards-desktop.stglab.manchester.uk.ibm.com> <alpine.DEB.1.10.1011121658360.5156@tp.orcam.me.uk> <20101115083222.GQ26513@bubble.grove.modra.org> <alpine.DEB.1.10.1012071839540.5345@tp.orcam.me.uk> <87y67ylk3r.fsf@firetop.home> <alpine.DEB.1.10.1012101427160.5345@tp.orcam.me.uk>
"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> On Thu, 9 Dec 2010, Richard Sandiford wrote:
>
>> > 2010-12-07 Maciej W. Rozycki <macro@codesourcery.com>
>> >
>> > gas/
>> > * config/tc-mips.h (TC_ADDRESS_BYTES): New macro.
>> > (mips_address_bytes): New prototype.
>> > * config/tc-mips.c (mips_address_bytes): New function.
>>
>> OK
>
> Thanks, I'll be applying the following change on top of that change then,
> unless you have any further concerns.
I think this is likely to break other targets that have 32-bit ABIs
and 64-bit architectures. A general fix along the lines of the
bfd.c:is32bit thing that I mentioned upthread would be needed first.
(That fix would also have worked for your three examples, without
the need for a MIPS-specific patch. The reason I didn't insist
is that a MIPS-specific change is needed for EABI64 (32-bit ELF,
64-bit addresses, ick.).)
Richard