Re: Relative expressions and ASSERT

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Thu, Dec 16, 2010 at 2:03 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Dec 16, 2010 at 3:02 AM, Alan Modra <amodra@gmail.com> wrote:
>> On Wed, Dec 15, 2010 at 08:25:17PM -0800, H.J. Lu wrote:
>>> On Thu, Aug 12, 2010 at 4:38 PM, Alan Modra <amodra@gmail.com> wrote:
>>> > On Thu, Aug 12, 2010 at 08:47:25AM -0700, H.J. Lu wrote:
>>> >> You can try the new linker on Linux kernel.
>>> >
>>> > An x86 2.6.35 kernel built without any differences.
>>> >
>>>
>>> It caused:
>>>
>>> http://sourceware.org/bugzilla/show_bug.cgi?id=12327
>>
>> I was expecting this to cause some trouble. ?You can't avoid breaking
>> some linker scripts when you change the linker expression evaluation
>> rules (really, give it some rules rather than the adhoc mess that was
>> there before). ?I wonder if I should have gone a little further, and
>> removed the special case for expressions outside of an output section
>> definition. ?It's what I really wanted to do, but ran into a number of
>> testsuite failures in our own testsuite when I originally tried that.
>> Now that we differentiate between plain numbers and absolute symbols,
>> only one testcase needs adjusting.
>>
>> So, if I commit this, scripts like the testcase below will need some
>> asjustment. ?On the other hand, sym1 = sym2 assignments should work
>> like they used to outside of an output section statement, fixing the
>> kernel problem and
>> frv-linux FAIL: FRV uClinux PIC relocs to weak undefined symbols, pie linking
>> frv-linux FAIL: FRV uClinux PIC relocs to weak undefined symbols, shared linking
>>
>> How to people feel about this for 2.21.1?
>>
>
> This patch works for me.
>
>
> --
> H.J.
> --
> ld/
>
> 2010-12-16 ?H.J. Lu ?<hongjiu.lu@intel.com>
>
> ? ? ? ?PR ld/12327
> ? ? ? ?* ldexp.c (exp_fold_tree_1): Don't make subexpressions absolute
> ? ? ? ?on etree_name.
>
> ld/testsuite/
>
> 2010-12-16 ?H.J. Lu ?<hongjiu.lu@intel.com>
>
> ? ? ? ?PR ld/12327
> ? ? ? ?* ld-scripts/defined.exp: Run defined4.
>
> ? ? ? ?* ld-scripts/defined4.d: New.
> ? ? ? ?* ld-scripts/defined4.s: Likewise.
> ? ? ? ?* ld-scripts/defined4.t: Likewise.
>

It failed normal kernel build:

ld: kernel image bigger than KERNEL_IMAGE_SIZE


-- 
H.J.