This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR ld/12507: Can't build a program with -flto -nostdlib
On Fri, Feb 25, 2011 at 3:58 PM, Alan Modra <amodra@gmail.com> wrote:
> On Fri, Feb 25, 2011 at 03:45:14PM -0800, H.J. Lu wrote:
>> On Fri, Feb 25, 2011 at 3:29 PM, Alan Modra <amodra@gmail.com> wrote:
>> > It would be better to put the entry symbol, and -u syms on the
>> > entry_symbol chain, into non_ironly_hash.
>>
>> I tried it and it doesn't work.
>
> How so?
>
>> Also, we only care about the entry symbol for LTO.
>
> I'd be a little surprised if there is a good reason to treat -u syms
> any differently from references in non-ir object files.
>
This patch works.
--
H.J.
---
diff --git a/ld/plugin.c b/ld/plugin.c
index 7892e36..40acbdb 100644
--- a/ld/plugin.c
+++ b/ld/plugin.c
@@ -492,8 +492,7 @@ get_symbols (const void *handle, int nsyms, struct ld_plugin
_symbol *syms)
symbol is externally visible. */
ironly = (!is_visible_from_outside (&syms[n], owner_sec, blhe)
&& !bfd_hash_lookup (non_ironly_hash, syms[n].name,
- FALSE, FALSE)
- && strcmp (syms[n].name, entry_symbol.name) != 0);
+ FALSE, FALSE));
/* If it was originally undefined or common, then it has been
resolved; determine how. */
@@ -838,6 +837,8 @@ plugin_call_cleanup (void)
static void
init_non_ironly_hash (void)
{
+ struct bfd_sym_chain *sym;
+
if (non_ironly_hash == NULL)
{
non_ironly_hash =
@@ -847,6 +848,12 @@ init_non_ironly_hash (void)
sizeof (struct bfd_hash_entry),
61))
einfo (_("%P%F: bfd_hash_table_init failed: %E\n"));
+
+ for (sym = &entry_symbol; sym != NULL; sym = sym->next)
+ if (sym->name
+ && !bfd_hash_lookup (non_ironly_hash, sym->name, TRUE, TRUE))
+ einfo (_("%P%X: hash table failure adding symbol %s\n"),
+ sym->name);
}
}