This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFA] bfd, elf32-i386.c (elf_i386_relocate_section): Document fall through.
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, binutils at sourceware dot org
- Date: Sat, 5 Mar 2011 17:37:29 -0800
- Subject: Re: [RFA] bfd, elf32-i386.c (elf_i386_relocate_section): Document fall through.
- References: <4D72DBF4.9080401@vmware.com>
On Sat, Mar 5, 2011 at 4:57 PM, Michael Snyder <msnyder@vmware.com> wrote:
> There could be a break statement missing here.
> If not, then it is good to comment the fact.
>
> OK?
>
>
> 2011-03-05 ?Michael Snyder ?<msnyder@vmware.com>
>
> ? ? ? ?* elf32-i386.c (elf_i386_relocate_section): Document fall through.
>
> Index: elf32-i386.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/elf32-i386.c,v
> retrieving revision 1.242
> diff -u -p -r1.242 elf32-i386.c
> --- elf32-i386.c ? ? ? ?6 Jan 2011 18:45:05 -0000 ? ? ? 1.242
> +++ elf32-i386.c ? ? ? ?6 Mar 2011 00:53:50 -0000
> @@ -3128,7 +3128,7 @@ elf_i386_relocate_section (bfd *output_b
> ? ? ? ? ? ? ? ? ? ? internal symbol, we have updated addend. ?*/
> ? ? ? ? ? ? ? ? ?continue;
> ? ? ? ? ? ? ? ?}
> -
> + ? ? ? ? ? ? /* FALLTHROUGH */
> ? ? ? ? ? ?case R_386_PC32:
> ? ? ? ? ? ?case R_386_PLT32:
> ? ? ? ? ? ? ?goto do_relocation;
>
>
OK. Thanks.
--
H.J.