This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] bfd, elf64-x86-64.c (elf_x86_64_relocate_section): document fall through.


H.J. Lu wrote:
On Sat, Mar 5, 2011 at 5:09 PM, Michael Snyder <msnyder@vmware.com> wrote:
Assuming that it was meant to fall through.

OK?


2011-03-05 Michael Snyder <msnyder@vmware.com>


       * elf64-x86-64.c (elf_x86_64_relocate_section): Document
       that case statement falls through intentionally.

Index: elf64-x86-64.c
===================================================================
RCS file: /cvs/src/src/bfd/elf64-x86-64.c,v
retrieving revision 1.214
diff -u -p -r1.214 elf64-x86-64.c
--- elf64-x86-64.c      4 Mar 2011 00:38:29 -0000       1.214
+++ elf64-x86-64.c      6 Mar 2011 01:02:50 -0000
@@ -2887,6 +2887,7 @@ elf_x86_64_relocate_section (bfd *output
           case R_X86_64_32:
             if (ABI_64_P (output_bfd))
               goto do_relocation;
+             /* FALLTHROUGH */
           case R_X86_64_64:
             if (rel->r_addend != 0)
               {



OK. Thanks.

Committed. Thanks for the review.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]