This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] ar.c (map_over_members): Plug memory leak.

From: Richard Sandiford <richard dot sandiford at linaro dot org>
To: Olaf van der Spek <olafvdspek at gmail dot com>
Cc: Michael Snyder <msnyder at vmware dot com>, "binutils\ at sourceware dot org" <binutils at sourceware dot org>
Date: Tue, 15 Mar 2011 11:59:25 +0000
Subject: Re: [RFA] ar.c (map_over_members): Plug memory leak.
References: <4D769107.2010906@vmware.com> <g4bp1c1ugt.fsf@linaro.org> <AANLkTikKH+0agMM4t-vBZ60JSENcoMOqKKRBpxD1E0Na@mail.gmail.com>

Olaf van der Spek <olafvdspek@gmail.com> writes:
> On Tue, Mar 15, 2011 at 12:41 PM, Richard Sandiford
> <richard.sandiford@linaro.org> wrote:
>> Maybe I'm being dense, but I don't get this. ÂDoes it even compile?
>
> Why would it not compile?

Because the final "free (filename);" is in the outermost block of the
function, but the "filename" variable is declared within a nested loop.

Richard

References:
- [RFA] ar.c (map_over_members): Plug memory leak.
  - From: Michael Snyder
- Re: [RFA] ar.c (map_over_members): Plug memory leak.
  - From: Richard Sandiford
- Re: [RFA] ar.c (map_over_members): Plug memory leak.
  - From: Olaf van der Spek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]