This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold patch] final_layout.sh fails depending on symbol table order
- From: Ian Lance Taylor <iant at google dot com>
- To: Cary Coutant <ccoutant at google dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Fri, 25 Mar 2011 15:38:58 -0700
- Subject: Re: [gold patch] final_layout.sh fails depending on symbol table order
- References: <AANLkTi=Y=74gh=ivDkGrz0Hmd4TKq6oxQ535Uv_=9hku@mail.gmail.com>
Cary Coutant <ccoutant@google.com> writes:
> The recent patch to testsuite/final_layout.sh (to eliminate the
> dependency on dc) now simply checks the order of the variables in nm
> output, but nm output is not always in address order:
>
> 0000000000401acc B global_vara
> 0000000000401ac8 B global_varb
> 0000000000401ad0 B global_varc
>
> The script is checking that global_varb comes before global_vara, but
> fails here because the symbol table is not in address order. Adding
> the -n option to the nm call fixes this.
> * testsuite/Makefile.am (final_layout.stdout): Use -n option with nm.
> * testsuite/Makefile.in: Regenerate.
Arrghh, I wrote this myself but I forgot to check it in. Please do
check in your patch. Thanks.
Ian