This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] C6X readelf unwinding table parsing


On Tue, 22 Mar 2011, Paul Brook wrote:

> The attached patch teaches readelf -u how to grok the C6X ABI defined 
> unwinding tables.  These are similar to those used by ARM, so much of the code 
> is shared.  Notable differences are the handling of PREL31 offsets, different 
> unwinding opcodes, and the addition of two more standard personality routines.
> 
> Ok?

This is OK in C6X terms (and you can approve the ARM changes yourself), 
presuming that:

* A subsequent patch (adding the assembler support for generating these 
tables) will add testcases covering this decoding code.

* It is deliberate that you don't try to represent the big-endian pair 
swapping when describing instructions to pop registers.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]