This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch]: complete coff/rs6000.h
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: Tristan Gingold <gingold at adacore dot com>
- Cc: binutils Development <binutils at sourceware dot org>
- Date: Tue, 03 May 2011 09:35:32 +0100
- Subject: Re: [Patch]: complete coff/rs6000.h
- References: <BB3EC980-9373-46F8-A942-05EC8D2BA877@adacore.com>
Tristan Gingold <gingold@adacore.com> writes:
> @@ -173,6 +173,8 @@ union external_auxent {
> struct {
> char x_zeroes[4];
> char x_offset[4];
> + char x_pad[E_FILNMLEN - 8];
> + char x_ftype[1];
> } x_n;
> } x_file;
>
x_ftype applies to both name encodings, so something like the syment
definition would seem better. (That'd mean changing the bfd code too,
of course.)
> @@ -276,3 +278,12 @@ struct external_ldrel
> };
>
> #define LDRELSZ (2 * 4 + 2 * 2)
> +
> +struct external_exceptab
> +{
> + bfd_byte e_addr[4];
> + bfd_byte e_lang[1];
> + bfd_byte e_reason[1];
> +};
> +
> +#define EXCEPTSZ (4 + 2)
This part's OK though. Please add the corresponding 64-bit definition
to rs6k64.h while you're there, to keep the two in sync.
Richard