This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: gas -Werror compilation break [Re: [patch ld bfd gas]: Handle linkonce for cfi generated debug_frame and eh_frame data]
- From: Dave Korn <dave dot korn dot cygwin at gmail dot com>
- To: Binutils <binutils at sourceware dot org>
- Date: Fri, 06 May 2011 18:57:27 +0100
- Subject: Re: gas -Werror compilation break [Re: [patch ld bfd gas]: Handle linkonce for cfi generated debug_frame and eh_frame data]
- References: <BANLkTi=_hynUgqW5UjHDSvtWox2UshG=FQ@mail.gmail.com> <BANLkTinQxcD6pcyna-_AusTeXaTy8J6Knw@mail.gmail.com> <BANLkTi=SOrur_bPOMM5GKPtozYT0pw8vEw@mail.gmail.com> <BANLkTim3DpFxpY+yjuGExYWPZXRE3xwvag@mail.gmail.com> <4DB6E500.5030807@redhat.com> <20110427203457.GA12977@host1.jankratochvil.net> <4DC1EF60.5050308@gmail.com> <20110505084454.GH7018@bubble.grove.modra.org> <20110505132113.GI7018@bubble.grove.modra.org>
On 05/05/2011 14:21, Alan Modra wrote:
> On Thu, May 05, 2011 at 06:14:54PM +0930, Alan Modra wrote:
>> I'll be committing the following instead, which I wrote a couple of
>> days ago but didn't get around to installing, or even writing a
>> changelog.
>
> Now committed with this ChangeLog entry.
>
> * dw2gencfi.c (SUPPORT_FRAME_LINKONCE): Define. Use throughout
> file to conditionally compile code added 2011-04-26.
> (cfi_change_reg_numbers): Add ATTRIBUTE_UNUSED on params only used
> when SUPPORT_FRAME_LINKONCE.
> (get_cfi_seg): Likewise. Reintroduce old code for when not
> SUPPORT_FRAME_LINKONCE.
> (cfi_finish): Move get_cfi_seg calls out of loop when not
> SUPPORT_FRAME_LINKONCE. Avoid unused var warning.
>
Hmm, still getting this:
> /n/10/davek/binutils/src.clean/gas/dw2gencfi.c: In function 'cfi_finish':
> /n/10/davek/binutils/src.clean/gas/dw2gencfi.c:1903:17: error: variable 'ccseg' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
>
> make[4]: *** [dw2gencfi.o] Error 1
... on x86_64-linux with rev 1.53 of dw2gencfi.c.
cheers,
DaveK