This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH,plugins,head+2.21] Fix pr12365 on COFF.
- From: Alan Modra <amodra at gmail dot com>
- To: Dave Korn <dave dot korn dot cygwin at gmail dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Sat, 7 May 2011 15:43:06 +0930
- Subject: Re: [PATCH,plugins,head+2.21] Fix pr12365 on COFF.
- References: <4DC431C1.3050406@gmail.com>
On Fri, May 06, 2011 at 06:37:05PM +0100, Dave Korn wrote:
> Tested on i686-pc-cygwin, fixes PR12365 and current failures in the
> ld-plugin tests and HJ's lto tests except for the ones that rely on mixed IR
> and non-IR relocatable links.
>
> OK for head and backport to branch in a couple of days time?
OK.
> + /* Complain if definition comes from a discarded section. */
> + if (ps->flags & SEC_EXCLUDE)
Strictly speaking this only tests for one class of discarded sections.
I'm happy with the test, just the comment is a little misleading.
--
Alan Modra
Australia Development Lab, IBM