This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [GOLD][PATCH PROPOSAL] prevent discarding of needed local symbols for the relocatable objects
- From: Ian Lance Taylor <iant at google dot com>
- To: Cary Coutant <ccoutant at google dot com>
- Cc: vkutuzov at accesssoftek dot com, binutils <binutils at sourceware dot org>
- Date: Tue, 10 May 2011 16:54:47 -0700
- Subject: Re: [GOLD][PATCH PROPOSAL] prevent discarding of needed local symbols for the relocatable objects
- References: <1265843004.2150.342.camel@dp690-dev5v4> <mcraavgcydc.fsf@dhcp-172-17-9-151.mtv.corp.google.com> <1267053412.6817.190.camel@dp690-dev5v4> <mcrlje9jj32.fsf@dhcp-172-17-9-151.mtv.corp.google.com> <BANLkTi=bPWCtfFvrgeRtbu3moYvY3mxE6Q@mail.gmail.com>
Cary Coutant <ccoutant@google.com> writes:
> This patch fixes the problem. Is this OK, or were you thinking that
> do_finalize_local_symbols() shouldn't even assign the symbol index
> when -s is set?
I was thinking the latter. I see that do_count_local_symbols checks
discard_locals. It sounds like it should also test strip_all. A patch
for that is preapproved if it works.
Thanks.
Ian