This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [SH] Allow R_SH_TLS_LE_32 for PIE

From: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
To: amodra at gmail dot com
Cc: binutils at sourceware dot org
Date: Thu, 23 Jun 2011 09:51:57 +0900 (JST)
Subject: Re: [SH] Allow R_SH_TLS_LE_32 for PIE
References: <20110623.070412.514761441.kkojima@rr.iij4u.or.jp> <20110623001209.GT21332@bubble.grove.modra.org>

Alan Modra wrote:
>>  	case R_SH_TLS_LE_32:
>> -	  if (info->shared)
>> +	  if (info->shared && !info->pie)
> 
> I should have spoken up when I saw the arm patch go by as we now have
> alpha and sh using the same code..  It doesn't really matter, but the
> condition here is better written as
> 
> 	  if (!info->executable)

Agreed.  Hope the patch for m68k will use info->executable :-)

Regards,
	kaz

References:
- [SH] Allow R_SH_TLS_LE_32 for PIE
  - From: Kaz Kojima
- Re: [SH] Allow R_SH_TLS_LE_32 for PIE
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]