This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MIPS/GAS/testsuite: Fine-grained MIPS FP ISA matching


"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> On Wed, 10 Aug 2011, Richard Sandiford wrote:
>
>> > -    run_dump_test_arches "mips5"	[mips_arch_list_matching mips5]
>> > +    run_dump_test_arches "mips5"	[mips_arch_list_matching fpisa5]
>> 
>> ...please also rename mips5 to mips5-fp (as part of the same commit
>> or separately, whichever you prefer).
>
>  Are you sure that is needed?

The name of the test should be consistent with the condition.  I asked
because I wanted the mips5 test to be consistent with mips4-fp.  So yes,
please do rename.

> Please note that the MIPS V ISA only added FP instructions

Sure, I realise that.

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]