This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MIPS/BFD: Fix assertions with SGI IRIX files


On Wed, 31 Aug 2011, Richard Sandiford wrote:

> >> A patch to remove the assertions is pre-approved if you agree that's OK.
> >
> >  OK, but are you positive that'll be no regression?
> 
> This is binutils.  You can never be positive that a patch won't break
> something.  But the handling of SHN_MIPS_DATA and SHN_MIPS_TEXT isn't
> written in an SGI-specific way (just as the handling of the other
> SHN_MIPS_* sections isn't written in an SGI-specific way).  I couldn't see,
> and still can't see, a reason why removing the assertions is wrong.

 OK, this is good enough a justification for me, thanks for investigating.  
I meant any improper handling within BFD itself of course.  I'll make that 
change and push it at my earliest convenience.  It may take a couple of 
days.

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]