This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: is_elf_format usage in ld testsuite?


On Fri, Nov 04, 2011 at 07:00:50AM +0100, Andreas Tobler wrote:
> On 04.11.11 03:20, Hans-Peter Nilsson wrote:
> >On Thu, 3 Nov 2011, Andreas Tobler wrote:
> >>ld-elf/binutils.exp:
> >>---
> >># Make sure that binutils can correctly handle ld output in ELF.
> >>
> >>if { ![istarget *-*-linux*]
> >>      &&  ![istarget *-*-gnu*]} {
> >>	return
> >>}
> >>---
> >>
> >>These tests run fine under FreeBSD for example. But these targets are not on
> >>the test above.
> >>Is there a special reason why we do not check with the is_elf_format proc
> >>instead?
> >
> >Some of those tests require the target to support shared
> >libraries, which is not true for all binutils ELF targets.
> 
> Ok.
> 
> Then I take it this way, everywhere in the test suite (binutils/ld)
> where we 'check' on ELF I use the already existing pattern to match
> my target. So for the above I'd add my target like this:
> 
> ---
> if { ![istarget *-*-linux*]
> 	&&  ![istarget *-*-freebsd*] <--- my target.
>       	&&  ![istarget *-*-gnu*]} {
>  	return
> }
> ---
> 
> Am I right?

Yes.  As well as the reason given by Hans-Peter, these tests are not
enabled on more targets simply because the originator of the tests did
not have the time or machines available to test on other targets.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]