Re: [PATCH] Using -fPIC for libiberty on s390x

[Martin Schwidefsky <schwidefsky at de dot ibm dot com>]

On Mon, 5 Dec 2011 10:24:12 -0500
Mike Frysinger <vapier@gentoo.org> wrote:

> On Monday 05 December 2011 03:46:55 Martin Schwidefsky wrote:
> > On Mon, 5 Dec 2011 02:02:10 -0500 Mike Frysinger wrote:
> > > i've run into this issue on Gentoo systems and binutils-2.22.  but now
> > > with all the pic code being unified with gcc, we need to do:
> > > 
> > > --- a/config/picflag.m4
> > > +++ b/config/picflag.m4
> > > @@ -51,6 +51,9 @@ case "${$2}" in
> > >      m68k-*-*)
> > >  	$1=-fpic
> > >  	;;
> > > +    s390x*-*-*)
> > > +	$1=-fPIC
> > > +	;;
> > >      s390*-*-*)
> > >  	$1=-fpic
> > >  	;;
> > 
> > Whenever you see a R_390_GOT12 relocation truncated to fit, the correct
> > solution is to switch from -fpic to -fPIC. I assume that the picflag.m4
> > replace the old configure.ac solution, no?
> 
> yeah, seems all the picflag logic has been consolidated in picflag.m4 in the gcc 
> project.  i can send a patch there if you want.

Please do so.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

Attachment: signature.asc
Description: PGP signature