This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch v2]: Fix ld pr11138 FAILures on mips*.
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: David Daney <david dot daney at cavium dot com>
- Cc: binutils <binutils at sourceware dot org>, Alan Modra <amodra at gmail dot com>, Manuel Lauss <manuel dot lauss at googlemail dot com>, Debian MIPS <debian-mips at lists dot debian dot org>, linux-mips <linux-mips at linux-mips dot org>
- Date: Sat, 10 Dec 2011 10:19:20 +0000
- Subject: Re: [Patch v2]: Fix ld pr11138 FAILures on mips*.
- References: <4EE27012.5030508@cavium.com> <20111210003928.GC2461@bubble.grove.modra.org> <4EE2ACB9.9010301@cavium.com>
David Daney <david.daney@cavium.com> writes:
> I will wait a couple of days to give Richard a chance to object.
Looks good to me too. Thanks for doing this. I think it should go
on the 2.22 branch as well.
> I am especially concerned about what happens on IRIX where the symbol
> comes in from an external object rather than being generated by the
> linker itself. I had no way to test that.
Me neither, unfortunately. But I agree it looks right. There's a
possibility that we could create the dynamic sections before the
definition of __rld_obj_head has been read in (e.g. from the
check_relocs of a previous object). In that case it looks like
we would create the .rld_map section and __rld_map/__RLD_MAP symbol,
then later switch to __rld_obj_head. .rld_map would then be left
at zero size and the __rld_map/__RLD_MAP symbol would be ignored
when setting the tag value. But your patch preserves the
behaviour in that case too.
Richard